Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Geolocation Sensor (harmful) #399

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Add Geolocation Sensor (harmful) #399

merged 1 commit into from
Jul 23, 2020

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jul 21, 2020

Closes #36.

@annevk annevk requested a review from martinthomson July 21, 2020 11:54
tantek
tantek approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@tantek tantek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and there's no dispute about the position on #36. Only requests are external to this pull request:

Thanks!

@annevk annevk mentioned this pull request Jul 22, 2020
Closed
@annevk
Copy link
Contributor Author

annevk commented Jul 22, 2020

Thanks, I've done that. I'll give this some time in case other people want to chime in as it's been a while since we last touched these sensor issues.

@annevk annevk force-pushed the annevk/geolocation-sensor branch from 5bd756d to f549ccf Compare July 23, 2020 08:01
@annevk annevk merged commit 326d719 into master Jul 23, 2020
@annevk annevk deleted the annevk/geolocation-sensor branch July 23, 2020 08:02
@marcoscaceres marcoscaceres mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@martinthomson martinthomson martinthomson approved these changes

@tantek tantek tantek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geolocation using Generic Sensor API
4 participants
@annevk @tantek @martinthomson @marcoscaceres