Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update title, url, and org of Permissions Policy (formerly Feature Policy) #348

Merged
merged 1 commit into from
May 27, 2020

Conversation

dbaron
Copy link
Contributor

@dbaron dbaron commented May 26, 2020

(note that the sorting by title means the entry moves)

@dbaron dbaron requested a review from annevk May 26, 2020 19:20
@dbaron dbaron self-assigned this May 26, 2020
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Odd that the webappsec draft doesn't even mention "Feature Policy" as a string any more, e.g. in a "Changes" appendix summarizing changes since previous public draft. I may file an issue for them to do so unless there's a reason not to.

Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our remaining concerns are being addressed now (naming was one of them and this was our suggested solution), but maybe we should update that separately from this more editorial PR.

I might even go as far as suggesting this is important to us now as this cements the way we think about permissions and third-parties in general.

(I created a PR for Tantek's remark.)

@martinthomson
Copy link
Member

I would support a change to "important" also.

The URL of the spec remains the same, which is awkward.

@dbaron dbaron merged commit 1829ac1 into mozilla:master May 27, 2020
@dbaron
Copy link
Contributor Author

dbaron commented May 27, 2020

BTW, discussion about changing to important should probably go in #24.

@clelland
Copy link

clelland commented Oct 5, 2020

Re: #348 (comment)

Looking at this late -- the URL has changed (though the old one redirects) and is now canonically https://w3c.github.io/webappsec-permissions-policy/

tantek added a commit that referenced this pull request Oct 5, 2020
Per #348 (comment) link directly to webappsec-permissions-policy
martinthomson pushed a commit that referenced this pull request Oct 6, 2020
Per #348 (comment) link directly to webappsec-permissions-policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants