Modify logging to use SCCACHE_LOG. #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froydnj
suggested changes
Aug 4, 2020
As per #810, modify env_logger to use the SCCACHE_LOG environment variable instead of the RUST_LOG one. This is to enable control of sccache logs whilst debugging other rust binaries. Update docs for SCCACHE_LOG.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 26, 2020
… the presence of cache read failures r=froydnj This avoids a set of intermittent issues related to `zstd` decompression failures, which in the absence of these changes break the entire build. This also requires [updating an environment variable](mozilla/sccache#822), which we do in `client.mk` as well as documentation. Differential Revision: https://phabricator.services.mozilla.com/D88184
ambroff
pushed a commit
to ambroff/gecko
that referenced
this pull request
Nov 4, 2020
… the presence of cache read failures r=froydnj This avoids a set of intermittent issues related to `zstd` decompression failures, which in the absence of these changes break the entire build. This also requires [updating an environment variable](mozilla/sccache#822), which we do in `client.mk` as well as documentation. Differential Revision: https://phabricator.services.mozilla.com/D88184
|
This didn't update the sccache-dist binary, which still uses sccache/src/bin/sccache-dist/main.rs Line 433 in b3f4727 |
|
Thanks @mstange I must have missed this. I'm unavailable for the next week and will get to this in about 10 days. |
|
I've added this in #977. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #810, modify env_logger to use the SCCACHE_LOG environment
variable instead of the RUST_LOG one. This is to enable control of
sccache logs whilst debugging other rust binaries.