Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for key prefixes when using S3 as the storage #811

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

jakubadamw
Copy link
Contributor

The corresponding environment variable is SCCACHE_S3_KEY_PREFIX.

Closes #1.

The corresponding environment variable is `SCCACHE_S3_KEY_PREFIX`.
Copy link
Contributor

@froydnj froydnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but please fix up the formatting errors in the Travis logs.

@jakubadamw
Copy link
Contributor Author

This looks reasonable, but please fix up the formatting errors in the Travis logs.

Done! 🙂

@froydnj froydnj merged commit 86c76c7 into mozilla:master Jul 21, 2020
@froydnj
Copy link
Contributor

froydnj commented Jul 21, 2020

Thanks!

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jul 28, 2022
Was noticing some concerning stats when fixing some macOS builds where we were experiencing a ton of cache misses. This makes it so that there is a separate cache for each particular workflow which should hopefully reduce the amount of cache misses we experience and speed up CI by a lot.

Relates to mozilla/sccache#811
Pull Request resolved: #82103
Approved by: https://github.com/kit1980
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Jul 29, 2022
Summary:
Was noticing some concerning stats when fixing some macOS builds where we were experiencing a ton of cache misses. This makes it so that there is a separate cache for each particular workflow which should hopefully reduce the amount of cache misses we experience and speed up CI by a lot.

Relates to mozilla/sccache#811

Pull Request resolved: #82103
Approved by: https://github.com/kit1980

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b472852778eef777ac182e2efcc008429f5fc4fe

Reviewed By: osalpekar

Differential Revision: D38252446

Pulled By: seemethere

fbshipit-source-id: 8b02f581b133edd655cb7082d2596a2812f48c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Support for S3 prefixes
2 participants