fix msvc passthrough arguments #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to fix #802 for me. |
glandium
requested changes
Jul 1, 2020
mozilla#764 and its followon patch, mozilla#768, failed to take into account that passthrough arguments actually need to be passed through to the compiler invocation: they don't prevent caching, but they do need to be considered when computing the cache key...and when actually performing the compilation.
froydnj
force-pushed
the
fix-msvc-passthrough-arguments
branch
from
e3047d3
to
569bfc5
Compare
glandium
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#764 and its followon patch, #768, failed to take into account that
passthrough arguments actually need to be passed through to the compiler
invocation: they don't prevent caching, but they do need to be
considered when computing the cache key...and when actually performing
the compilation.