Clearly identify all error messages as coming from sccache. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
improve-error-msgs
branch
from
0c98e29
to
4f0832f
Compare
|
I don't understand what's going on with TravisCI here; the status page for this pull request has green builds, but somehow that's not being reflected into the pull request? Anyway, thanks for doing this; I'm going to merge this as-is. |
nnethercote
added a commit
to nnethercote/sccache
that referenced
this pull request
Jun 5, 2020
This finishes what mozilla#762 started. All `println!`/`eprintln!` calls now start with `sccache: `, except those involved in printing of requested data, such as stats.
froydnj
pushed a commit
that referenced
this pull request
Jun 5, 2020
This finishes what #762 started. All `println!`/`eprintln!` calls now start with `sccache: `, except those involved in printing of requested data, such as stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747.