Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support both -arg and /arg with msvc/clang-cl without altering paths #674

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Support both -arg and /arg with msvc/clang-cl without altering paths #674

merged 1 commit into from
Feb 28, 2020

Commits on Feb 27, 2020

  1. Support both -arg and /arg with msvc/clang-cl without altering paths 

    34c6f9a added support for /arg flags by replacing the initial slash with
a -, and falling back to normal argument parsing. Unfortunately, when
running clang-cl on a non-Windows system, that means absolute paths get
garbled, and that can lead to bad argument parsing with separate
arguments (e.g. -I /absolute/path).

We change the arguments definition for MSVC to include both styles, by
hacking up a macro that generates two lists, one with - arguments, and
one with / arguments. Merging the two lists at build time doesn't seem
possible without going full procedural macro.

Fixes mozilla#669
    @glandium
    glandium committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    41f994a View commit details
    Browse the repository at this point in the history