Use rustls for tls & trust-dns-resolver for dns resolution #1737
Conversation
By default, reqwest uses native-tls, which is openssl on linux and that makes cross-compilation very hard as they need to compile openssl themselves and exposes it via pkg-config. Enabling vendored-openssl does not help there because the dep:openssl is only enabled by dist-server. reqwest by default uses libc's getaddrinfo, which is a poor solution that requires a dedicated thread and it is not nearly as reliable as trust-dns-resolver, not to mention libc implementation, e.g. musl, might deliberately leave out some features. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
- Coverage 29.76% 29.16% -0.60%
==========================================
Files 49 49
Lines 17207 17452 +245
Branches 8321 8446 +125
==========================================
- Hits 5121 5090 -31
- Misses 7049 7292 +243
- Partials 5037 5070 +33 see 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
The build failure is caused by quinn-udp: quinn-rs/quinn#1469 @Xuanwo I have disabled dns-over-quic for now. |
quinn-rs/quinn#1469 Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
|
I've pushed again the fixed the |
|
@Xuanwo It seems that freebsd ci also failed on main with similar errors, so I think this PR should be ok to merge since it does not cause any regression. |
|
@drahnr Yes, I've verified that with I will open another PR to remove the openssl pulled in by |
|
@drahnr I've created #1738 to be merged after this to fix the openssl pulled in by dist-servers. It still needs some testing, since I'm using MacOS, I cannot test it locally without installing openssl for x86_64-linux, unless I rebase that PR above this one, which would make it a mess. So I've pushed it and let the ci tested it out, hope it would be ok, though it's the first time for me to use pkcs1 and do anything related to crypto, so I might made some mistakes, hope you would review it carefully to verify that it has no such bug. Thank you for taking your time to review my PR! |
That bug is for OpenBSD. Quinn CI covers FreeBSD, which seems to be working just fine. |
By default, reqwest uses native-tls, which is openssl on linux and that makes cross-compilation very hard as they need to compile openssl themselves and exposes it via pkg-config.
Enabling vendored-openssl does not help there because the dep:openssl is only enabled by dist-server.
reqwest by default uses libc's
getaddrinfo, which is a poor solution that requires a dedicated thread and it is not nearly as reliable as trust-dns-resolver, not to mention libc implementation, e.g. musl, might deliberately leave out some features.Signed-off-by: Jiahao XU [email protected]