Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect line numbers in error messages when using distributed compilation from Windows #893

Closed
mstange opened this issue Dec 3, 2020 · 0 comments · Fixed by #895
Closed

Comments

@mstange
Copy link
Contributor

mstange commented Dec 3, 2020

msvc.rs always passes "-EP" rather than "-E" in the preprocessing step:

cmd.arg("-EP")

"-EP" means "don't emit line number annotations".

Originally this was using "-E" (which does emit line number annotations), but it was changed to "-EP" in #723. This change mirrored a change to gcc.rs from #208. However, when support for distributed compilation was added in #249, gcc.rs was updated to only use "-P" when no distribution was happening:

4b04cb0#diff-33ed0b50ade3d44507b82055ded2e81fc58756670c39943d2b1305354c649dd6R353-R359

#249 did not make the equivalent change to msvc.rs.

msvc.rs should be updated similarly, so that it uses "-E" if may_dist and otherwise "-EP".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant