Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only block /FS when building with PDBs #859

Closed
obsgolem opened this issue Sep 29, 2020 · 0 comments · Fixed by #908
Closed

Only block /FS when building with PDBs #859

obsgolem opened this issue Sep 29, 2020 · 0 comments · Fixed by #908
Milestone
0.2.14

Comments

@obsgolem
Copy link

obsgolem commented Sep 29, 2020 •
edited
Loading

Currently /FS is marked as too hard to cache, see

sccache/src/compiler/msvc.rs

Line 266 in 5197fbb

msvc_flag!("FS", TooHardFlag),

This is problematic since CMake enables this flag for all MSVC builds on windows: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Platform/Windows-MSVC-CXX.cmake

It seems to me that caching with this flag is safe when building without /Zi.
@glandium glandium added this to the 0.2.14 milestone Dec 11, 2020
@glandium glandium mentioned this issue Dec 11, 2020
Merged
glandium added a commit to glandium/sccache that referenced this issue Dec 15, 2020
@glandium
Ignore both -FS and -MP on MSVC
1283021 
Fixes mozilla#859
glandium added a commit to glandium/sccache that referenced this issue Dec 15, 2020
@glandium
Ignore both -FS and -MP on MSVC
5a086a8 
Fixes mozilla#859
@glandium glandium mentioned this issue Dec 16, 2020
Merged
glandium added a commit that referenced this issue Dec 16, 2020
@glandium
Ignore both -FS and -MP on MSVC
da1dd3b 
Fixes #859
Xanewok referenced this issue in paritytech/cachepot Apr 2, 2021
@glandium @Xanewok
Ignore both -FS and -MP on MSVC
354e17a 
Fixes #859
drahnr referenced this issue in paritytech/cachepot Apr 6, 2021
@glandium @drahnr
Ignore both -FS and -MP on MSVC
b9f4667 
Fixes #859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.14
Development

Successfully merging a pull request may close this issue.

Ignore both -FS and -MP on MSVC glandium/sccache
2 participants
@glandium @obsgolem