Skip to content

Commit

Permalink
bump minimum rust version to 1.41.1
Browse files Browse the repository at this point in the history
Removes a chunk from the readme regarding a false positive
rustc-wrapper entry not being used, which is closed since 1.40.0 .
Cargo issue: rust-lang/cargo#7745
  • Loading branch information
drahnr authored and froydnj committed Mar 18, 2020
1 parent 8816c2f commit 32dc8b0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ matrix:
- os: osx

# rustc version compat
- rust: 1.36.0 # oldest supported version, keep in sync with README.md
- rust: 1.36.0
- rust: 1.41.1 # oldest supported version, keep in sync with README.md
- rust: 1.41.1
env: DIST_SCCACHE=1
- rust: beta
- rust: nightly
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Table of Contents (ToC)
Build Requirements
------------------

Sccache is a [Rust](https://www.rust-lang.org/) program. Building it requires `cargo` (and thus `rustc`). sccache currently requires **Rust 1.36.0**.
Sccache is a [Rust](https://www.rust-lang.org/) program. Building it requires `cargo` (and thus `rustc`). sccache currently requires **Rust 1.41.1**.

We recommend you install Rust via [Rustup](https://rustup.rs/). The generated binaries can be built so that they are very [portable](#building-portable-binaries). By default `sccache` supports a local disk cache. To build `sccache` with support for `S3` and/or `Redis` cache backends, add `--features=all` or select a specific feature by passing `s3`, `gcs`, and/or `redis`. Refer the [Cargo Documentation](http://doc.crates.io/manifest.html#the-features-section) for details.

Expand Down Expand Up @@ -147,8 +147,7 @@ in `$HOME/.cargo/config` by adding:
rustc-wrapper = "/path/to/sccache"
```

Note that you need to use cargo 1.40 or newer for this to work. (In cargo 1.40 you will see a warning about this
configuration not being used. This is a false positive. The warning will go away in future releases.)
Note that you need to use cargo 1.40 or newer for this to work.

Alternatively you can use the environment variable `RUSTC_WRAPPER`:

Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ for:
target: x86_64-pc-windows-msvc
- channel: nightly
target: x86_64-pc-windows-msvc
- channel: 1.36.0 # Oldest supported version. Keep in sync with README.md.
- channel: 1.41.1 # Oldest supported version. Keep in sync with README.md.
target: x86_64-pc-windows-msvc
# Build a release build on master to make sure it builds.
- channel: stable
Expand Down

0 comments on commit 32dc8b0

Please sign in to comment.