Fix warnings

[oswetto]

No description provided.

[gbrail]

Thanks for working on improving the codebase!

It looks like this PR mainly adds SerialVersionUIDs where they're missing. However, for backward compatibility and general goodness, I think we should follow the existing pattern in the codebase of including the generated UID (as generated by "serialver" or your IDE) rather than setting them all to 1.

Also it looks like the Checkstyle checks fail in the Jenkins build. You can check these yourself by running "./gradlew check".

[gbrail]

This looks basically fine, although I see some public methods removed from "NativeError". I'd prefer if this change stuck to formatting and serialVersionUID stuff, and furthermore I'm not sure why we'd want to remove those.

Also, I see a lot of test failures in Jenkins... does running "./gradlew check" work for you?

[gbrail]

This is making progress and thanks for sticking with it! However if we're going to change serialVersionUIDs we have to be very careful not to break backward compatibility, in the event that someone is relying on this stuff.

So... if a class has no serial version at all, then it makes sense to add one, and adding it by running "serialver" as you did is the correct way because it sets it to the current value that Java will generate automatically.

However, if a class already has one, even if it is 1, then changing that will break compatibility for serialized objects.

So in order to guarantee that nothing breaks, then this change should add serialVersionUID using serialver if they don't exist at all, which is what you have done. However, it should not change any existing ones even if they are set to 1.

Thanks!

[gbrail]

Almost! But I count three more "-1s" that we still should not remove.

[gbrail]

Now that looks right. Thanks!