-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
384 - member box call error #353
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
testsrc/org/mozilla/javascript/tests/MemberBoxCallTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
package org.mozilla.javascript.tests; | ||
|
||
import org.junit.Test; | ||
import org.junit.Before; | ||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertNull; | ||
|
||
import org.mozilla.javascript.*; | ||
import org.mozilla.javascript.annotations.*; | ||
|
||
public class MemberBoxCallTest { | ||
|
||
Scriptable scope; | ||
|
||
@Test | ||
public void testPrototypeProperty() { | ||
Context cx = Context.enter(); | ||
try { | ||
assertEquals(evaluate(cx, | ||
"var hostObj = new AnnotatedHostObject(); " + | ||
"var valueProperty = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(hostObj), \"foo\");" + | ||
"var result = 'failed';" + | ||
"if( valueProperty.get && valueProperty.set ) {" + | ||
"valueProperty.set.call(hostObj, 'superVal');" + | ||
"result = valueProperty.get.call(hostObj);" + | ||
"}"+ | ||
"result;"), "SUPERVAL"); | ||
} finally { | ||
Context.exit(); | ||
} | ||
} | ||
|
||
private Object evaluate(Context cx, String str) { | ||
return cx.evaluateString(scope, str, "<testsrc>", 0, null); | ||
} | ||
|
||
|
||
@Before | ||
public void init() throws Exception { | ||
Context cx = Context.enter(); | ||
try { | ||
scope = cx.initStandardObjects(); | ||
ScriptableObject.defineClass(scope, AnnotatedHostObject.class); | ||
} finally { | ||
Context.exit(); | ||
} | ||
} | ||
|
||
public static class AnnotatedHostObject extends ScriptableObject { | ||
|
||
String foo, bar = "bar"; | ||
|
||
public AnnotatedHostObject() {} | ||
|
||
@Override | ||
public String getClassName() { | ||
return "AnnotatedHostObject"; | ||
} | ||
|
||
@JSConstructor | ||
public void jsConstructorMethod() { | ||
put("initialized", this, Boolean.TRUE); | ||
} | ||
|
||
@JSFunction | ||
public Object instanceFunction() { | ||
return "instanceFunction"; | ||
} | ||
|
||
@JSFunction("namedFunction") | ||
public Object someFunctionName() { | ||
return "namedFunction"; | ||
} | ||
|
||
@JSStaticFunction | ||
public static Object staticFunction() { | ||
return "staticFunction"; | ||
} | ||
|
||
@JSStaticFunction("namedStaticFunction") | ||
public static Object someStaticFunctionName() { | ||
return "namedStaticFunction"; | ||
} | ||
|
||
@JSGetter | ||
public String getFoo() { | ||
return foo; | ||
} | ||
|
||
@JSSetter | ||
public void setFoo(String foo) { | ||
this.foo = foo.toUpperCase(); | ||
} | ||
|
||
@JSGetter("bar") | ||
public String getMyBar() { | ||
return bar; | ||
} | ||
|
||
public void setBar(String bar) { | ||
this.bar = bar.toUpperCase(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few of properties and functions on "AnnotatedHostObject," but it looks like this test is only checking for "foo." Is there a reason why we can't test the other properties? Similarly, are you sure that all the code paths in ScriptableObject are being exercised here for both Member and MemberBox?