Add INDY ops for math operations #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us optimize them later, since most math operations are long chains of "instanceof" checks.
gbrail
force-pushed
the
indy-10-math-ops
branch
from
0c726b1 to
c3f06c3
Compare
|
This seems uncontroversial so I'm going to merge it, and happy to entertain questions any time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this makes the bytecode a tiny bit more readable IMO, and doesn't really affect performance.
Once we have these in, however, we can add additional type-specific linkers which will shorten the codepaths to these common operations for common types, and avoid the long strings of "instanceof" checks that make up most of the generic math operations today.