-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #780 fix Object.assign when undefined value and inextensible #1186
Conversation
Haven't looked at the changes, but haven't these fixes improved the test262 results? |
The |
Right...
Not just Computed Property Names though. Also at least a proper const impl and unicode regex |
* | ||
* <p>https://262.ecma-international.org/12.0/#sec-set-o-p-v-throw | ||
*/ | ||
public static void putOrThrow(Context cx, Scriptable obj, String name, Object value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abstract Object Operations as defined in the ecmascript spec ought to be placed in AbstractEcmaObjectOperations.
Please heck the guidelines at the top of the file for some instructions on how to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref. 204cd5f
I made to move to AbstractEcmaObjectOperations
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased it.
Yes -- this looks good. Thanks! |
ref. #780
I found another problem with it, so I fixed it while I was at it.