Skip to content

Commit

Permalink
as map/set/weakmap are supported by Rhino, we can enable one more test;
Browse files Browse the repository at this point in the history
In contrast to the original test, weakmap does not support symbols as key (have tested that with real browsers). Therfore i had to comment some lines.
  • Loading branch information
rbri authored and gbrail committed Oct 1, 2024
1 parent 95f232f commit e7d0a7d
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions tests/testsrc/jstests/harmony/v8-symbols.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,37 +245,35 @@ function TestCall() {
TestCall()


/*
* TODO Rhino not implemented
/* Rhino changed - weakmap does not support symbol keys */
function TestCollections() {
var set = new Set
var map = new Map
var weakmap = new WeakMap
for (var i in symbols) {
set.add(symbols[i])
map.set(symbols[i], i)
weakmap.set(symbols[i], i)
/* weakmap.set(symbols[i], i) */
}
assertEquals(symbols.length, set.size)
assertEquals(symbols.length, map.size)
for (var i in symbols) {
assertTrue(set.has(symbols[i]))
assertTrue(map.has(symbols[i]))
assertTrue(weakmap.has(symbols[i]))
/* assertTrue(weakmap.has(symbols[i])) */
assertEquals(i, map.get(symbols[i]))
assertEquals(i, weakmap.get(symbols[i]))
/* assertEquals(i, weakmap.get(symbols[i])) */
}
for (var i in symbols) {
assertTrue(set.delete(symbols[i]))
assertTrue(map.delete(symbols[i]))
assertTrue(weakmap.delete(symbols[i]))
/* assertTrue(weakmap.delete(symbols[i])) */
}
assertEquals(0, set.size)
assertEquals(0, map.size)
}
TestCollections()

*/

function TestKeySet(obj) {
//assertTrue(%HasFastProperties(obj))
Expand Down Expand Up @@ -364,9 +362,7 @@ function TestKeyDelete(obj) {
}
}

// TODO Rhino no Map
//var objs = [{}, [], Object.create(null), Object(1), new Map, function(){}]
var objs = [{}, [], Object.create(null), Object(1), function(){}]
var objs = [{}, [], Object.create(null), Object(1), new Map, function(){}]

for (var i in objs) {
//print('Testing ' + i + ' (' + typeof i + ')');
Expand Down

0 comments on commit e7d0a7d

Please sign in to comment.