Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort entries by -last_modified in monitor/changes changeset endpoint #725

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Dec 20, 2024

Mimic behaviour of monitor/changes records endpoint

The list of collections in the DevTools will now be sorted by -last_modified since the order of the list comes from the RemoteSettings.inspect() function (source)

@leplatrem
Copy link
Contributor Author

If we modify how changeset sorts things, there might be a few other impacts to think about. Like the remote-settings-devtools users. But that would be a clean solution if we make everything use changeset and it sorts things in an expected way.

You're right, clients would be instantiated by order of modified (collections with oldest last change would end up at the bottom). I think it's fine :) but let's look at this next year :)

@leplatrem
Copy link
Contributor Author

@leplatrem leplatrem merged commit 078d4d7 into main Jan 9, 2025
7 of 8 checks passed
@leplatrem leplatrem deleted the sort-changeset-monitor-changes branch January 9, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants