Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update expected metadata with null published times #866

Merged
merged 1 commit into from
May 10, 2024

Conversation

inhumantsar
Copy link
Contributor

While working on a separate issue, I ran node generate-testcase.js all to make debugging a little easier and noticed many testcases hadn't been updated to include publishedTime when it would result in a null value.

This PR adds those null values and apparently removes a newline from the visibility-hidden test case.

Copy link

@fchasen fchasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding that to so many tests.

@fchasen fchasen merged commit 97db40b into mozilla:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants