Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JS tests from Karma to Jasmine (Fixes #899) #942

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jun 21, 2024

Description

Migrates Protocol component JS tests from Karma (which is deprecated) to Jasmine Browser Runner. Also updates GitHub action for pull requests to run tests in Chrome in addition to Firefox.

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

#899

Testing

  • npm install
  • npm test

Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍚

@craigcook craigcook merged commit edf59b8 into mozilla:main Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants