Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial checkin of templates for DLP #1143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Initial checkin of templates for DLP #1143

wants to merge 4 commits into from

Conversation

mkaply
Copy link
Collaborator

@mkaply mkaply commented Aug 13, 2024

No description provided.

@mkaply
Copy link
Collaborator Author

mkaply commented Aug 13, 2024

@gregstoll Greg, this is the ADMX templates version. Can you take a look at the descriptions and see how I did?

Copy link
Contributor

@gregstoll gregstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -100,6 +100,7 @@
<string id="ProxySettings_group">Proxy Settings</string>
<string id="SecurityDevices_group">Security Devices</string>
<string id="FirefoxSuggest_group">Firefox Suggest (US only)</string>
<string id="ContentAnalysis_group">Content Analysis</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might use Content Analysis (DLP) here - the SUMO page refers to it as DLP ("Content Analysis" is just our internal name for it)


If this policy is disabled or not configured, the agent name "A DLP Agent" is used.</string>
<string id="ContentAnalysis_AgentTimeout">Agent Timeout</string>
<string id="ContentAnalysis_AgentTimeout_Explain">If this policy is enabled, you can specify the timeout in number of seconds after a DLP request is sent to the agent. After this timeout, the request will be denied unless `DefaultResult` is set to 1 or 2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is referring to the policy with id ContentAnalysis_DefaultResult below, so I think we should use "Default Result" here instead of DefaultResult?

<string id="ContentAnalysis_BypassForSameTabOperations">Bypass For Same Tab Operations</string>
<string id="ContentAnalysis_BypassForSameTabOperations_Explain">If this policy is enabled, Firefox will automatically allow DLP requests whose data comes from the same tab and frame - for example, if data is copied to the clipboard and then pasted on the same page.

If this policy is disabled or not configured, Firefox will not automatically allow DLP requests whose data comes from the same tab and frame.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead "If this policy is disabled or not configured, Firefox will not pass DLP requests whose data comes from the same tab and frame to the DLP agent as normal."

<string id="ContentAnalysis_PipePathName">Pipe Path Name</string>
<string id="ContentAnalysis_PipePathName_Explain">If this policy is enabled, you can change the name of the pipe for the DLP agent.

If this policy is disabled or not configured, the default pipe name of 'path_user'is used.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a space before the last "is"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants