Remove the unused PDFDocument.mainXRefEntriesOffset method
#9988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only is this method completely unused *now*, looking through the history of the code it never appears to have been used for anything either. Years ago `mainXRefEntriesOffset` was included when creating `XRef` instances, however it wasn't actually used for anything (the parameter was never checked, nor assigned to a property on `XRef`). If this method ever becomes useful (again) it's easy enough to restore it thanks to version control, but including dead code in the builds just seems wasteful.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7c411fde510c004/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6c5e7ec20643588/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6c5e7ec20643588/output.txt Total script time: 30.44 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7c411fde510c004/output.txt Total script time: 36.45 mins
|
timvandermeij
approved these changes
Aug 19, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only is this method completely unused now, looking through the history of the code it never appears to have been used for anything either.
Years ago
mainXRefEntriesOffsetwas included when creatingXRefinstances, however it wasn't actually used for anything (the parameter was never checked, nor assigned to a property onXRef).If this method ever becomes useful (again) it's easy enough to restore it thanks to version control, but including dead code in the builds just seems wasteful.