Attempt to throw MissingPDFException when applicable in node_stream.js (issue 9791)
#9964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
node-MissingPDFException
branch
from
6510a6d to
ac93db4
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/415d83cddba0a36/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e674a5fb39052e5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e674a5fb39052e5/output.txt Total script time: 28.75 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/415d83cddba0a36/output.txt Total script time: 35.81 mins
|
| let handleResponse = (response) => { | ||
| if (response.statusCode === 404) { | ||
| const error = new MissingPDFException(`Missing PDF "${this._url}".`); | ||
| this._storedError = error; |
There was a problem hiding this comment.
I think we might need return after this too to avoid setting the readable stream to a failed response, just like above.
There was a problem hiding this comment.
Yes, that seems reasonable; fixed now.
…m.js` (issue 9791)
Snuffleupagus
force-pushed
the
node-MissingPDFException
branch
from
ac93db4 to
f78efd8
Compare
timvandermeij
approved these changes
Aug 6, 2018
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm not very familiar with Node.js, this patch should (hopefully) cover the multiple ways in which files can be loaded in Node.js environments; while also taking into account e.g. the differences between the
XMLHttpRequestand the{http, https}.requestmethods.Furthermore, the
creates pdf doc from non-existent URLAPI unit-test now passes in Node.js/Travis.Fixes #9791.