[Regression] Convert Catalog.builtInCMapCache into a Map, instead of an Object, to ensure that it's correctly reset (PR 8064 follow-up)
#9935
Conversation
… of an Object, to ensure that it's correctly reset (PR 8064 follow-up) With the `builtInCMapCache` being a simple Object, it unfortunately means that the `Catalog.cleanup` method isn't resetting it as intended. By just replacing the `builtInCMapCache` with an empty Object, existing references to it will not actually be updated. The result is that e.g. `Page` instances still keeps references to, what should have been removed, CMap data. To fix these problems, the `builtInCMapCache` is converted into a `Map` instead (since it can be easily reset).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5f2cbf3ef022ac6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/616511a91229f8b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5f2cbf3ef022ac6/output.txt Total script time: 19.94 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/616511a91229f8b/output.txt Total script time: 26.97 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5d414b3ea7e9cbe/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5d414b3ea7e9cbe/output.txt Total script time: 3.01 mins Published |
|
Good find; thanks! |
|
@timvandermeij Thank you for landing this; and of course the other PRs yesterday :-) |
Fixes a regression from PR #8064 (split off from PR #9931 since it probably deserves more visibility).
With the
builtInCMapCachebeing a simple Object, it unfortunately means that theCatalog.cleanupmethod isn't resetting it as intended.By just replacing the
builtInCMapCachewith an empty Object, existing references to it will not actually be updated. The result is that e.g.Pageinstances still keeps references to, what should have been removed, CMap data.To fix these problems, the
builtInCMapCacheis converted into aMapinstead (since it can be easily reset).