Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed safari compatibility check (issue #9824) #9830

Merged
merged 1 commit into from
Jun 23, 2018

Conversation

EugeneSqr
Copy link
Contributor

@EugeneSqr EugeneSqr commented Jun 21, 2018

Fixes #9824

// Last tested with version 6.0.4.
if (isSafari || isIOS) {
compatibilityParams.disableRange = true;
compatibilityParams.disableStream = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these now being removed, all occurrences of apiCompatibilityParams.disableRange/apiCompatibilityParams.disableStream throughout the code-base will always be undefined and ought to be removed as well.

See also https://github.com/mozilla/pdf.js/wiki/Squashing-Commits

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e2c981cff6a7839/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e2c981cff6a7839/output.txt

Total script time: 8.56 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/16a2be22d32c37e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a68d01febf81b17/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/a68d01febf81b17/output.txt

Total script time: 23.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/16a2be22d32c37e/output.txt

Total script time: 38.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 34594a5 into mozilla:master Jun 23, 2018
@timvandermeij
Copy link
Contributor

Looks good. Thank you for improving this!

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Removed safari compatibility check (issue mozilla#9824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants