Remove Util.appendToArray and Util.prependToArray

[timvandermeij]

The former may be replaced by regular JavaScript array concatenation and the latter is unused. This avoids unnecessary function calls/imports.

[timvandermeij]

/botio-linux preview

[timvandermeij]

/botio test

[Snuffleupagus]

This avoids unnecessary function calls/imports.

While that's certainly correct, it will however result in more allocations[1] since the existing array won't be re-used; please refer to this MDN article:

The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array.

---

[1] Whether or not this would be a problem, I don't know. Using push instead of concat might work!?

[timvandermeij]

Good point! With the spread syntax, it's now possible to use the regular push operation instead of concat, so this both avoids additional method calls and reuses the original array. I have pushed the new version. Could you check if it's what you had in mind?

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c2a283c1d4a601f/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/c2a283c1d4a601f/output.txt

Total script time: 3.00 mins

Published

• Viewer: http://54.67.70.0:8877/c2a283c1d4a601f/web/viewer.html

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/da0a4bd7e532796/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4e61f19347b2287/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/da0a4bd7e532796/output.txt

Total script time: 19.13 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.215.176.217:8877/4e61f19347b2287/output.txt

Total script time: 23.23 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[Snuffleupagus]

Could you check if it's what you had in mind?

That looks great; and it's nice that more (old) code can be removed now!

---

A good follow-up might be to try and replace Util.extendObj with (the native) Object.assign too. It'd basically just be a search-and-replace exercise, but you'd probably need to add a (core-js) polyfill though.

[timvandermeij]

Thank you for checking this!