Don't block origin-less blob:-URLs in hosted viewer #9505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
approved these changes
Feb 23, 2018
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5c2e4467018be2d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5c2e4467018be2d/output.txt Total script time: 2.73 mins Published |
|
Thank you for improving this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Don't block origin-less blob:-URLs in hosted viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around a bug in IE11 (and IE10, earlier versions of IE do not support
URL.createObjectURLfor creatingblob:-URLs anyway) - #9498 .I could have checked for an empty or null
origin, but since the browser's Same-origin policy already blocks cross-originblob:-URL requests, I decided to have simpler code and just rely on the browser's same-origin policy enforcement for access control ofblob:-URLs.