-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect workerSrc if set #9459
Respect workerSrc if set #9459
Conversation
Respect user-defined workerSrc over internal overrides.
This change looks reasonable to me, but since I'm not too familiar with the worker logic, I would like a second pair of eyes here just to be sure I'm not missing anything. |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e370d2df7eeb250/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/98042e3c69b353b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/98042e3c69b353b/output.txt Total script time: 23.97 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e370d2df7eeb250/output.txt Total script time: 38.90 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current situation, where the workerSrc
option is being silently ignored in some cases seems far from ideal to me.
I suppose that the only caveat here would be if there's API consumers that managed to set an invalid workerSrc
, and where the current logic thus "saved" them.
However I'm not too worried about that, and besides my impression from questions/issues over the years is that it's a lot more common for users to have trouble because they did not set the workerSrc
option at all.
The above is thus a somewhat long-winded way of saying that I think this change is fine. Thanks for the patch!
Thanks! I appreciate the context. |
Respect workerSrc if set
Respect user-defined
workerSrc
over internal overrides.Resolves #9443.