Update comment regarding beforeprint event support #9439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"beforeprint" / "afterprint" are standard features these days, and Chrome added support for it in Chrome 63: https://www.chromestatus.com/feature/5700595042222080
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Update comment regarding beforeprint event support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"beforeprint" / "afterprint" are standard features these days, and Chrome added support for it in Chrome 63: https://www.chromestatus.com/feature/5700595042222080
This is just a comment update, the added events are not really useful for PDF.js because these events are synchronous and non-cancelable. For that we would need async print events, but that doesn't seem to happen anytime soon - whatwg/html#2532