Limit PDFFetchStream to http(s) in the Chrome extension #9363
+51
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fetch` API is only supported for http(s), even in Chrome extensions. Because of this limitation, we should use the XMLHttpRequest API when the requested URL is not a http(s) URL. Fixes mozilla#9361
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1ae3dd8260e8f95/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d766e33b9b7373a/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/1ae3dd8260e8f95/output.txt Total script time: 23.36 mins
Image differences available at: http://54.215.176.217:8877/1ae3dd8260e8f95/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d766e33b9b7373a/output.txt Total script time: 38.70 mins
|
Snuffleupagus
approved these changes
Jan 21, 2018
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
Feb 4, 2018
…examples This patch fixes a regression from mozilla#9363, causing the examples not to load anymore.
IsaacSchemm
pushed a commit
to IsaacSchemm/pdf.js-seamonkey
that referenced
this pull request
Mar 15, 2018
…examples This patch fixes a regression from mozilla#9363, causing the examples not to load anymore. (cherry picked from commit 1f9878e)
ltetzlaff
pushed a commit
to ltetzlaff/pdf.js
that referenced
this pull request
Apr 24, 2018
…examples This patch fixes a regression from mozilla#9363, causing the examples not to load anymore.
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Limit PDFFetchStream to http(s) in the Chrome extension
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…examples This patch fixes a regression from mozilla#9363, causing the examples not to load anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fetchAPI is only supported for http(s), even in Chrome extensions. Because of this limitation, we should use theXMLHttpRequestAPI when the requested URL is not a http(s) URL.Fixes #9361