Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of compatibility.js from examples #9122

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Remove mentions of compatibility.js from examples #9122

merged 1 commit into from
Nov 16, 2017

Conversation

wojtekmaj
Copy link
Contributor

No description provided.

@@ -68,7 +68,6 @@ $ cd pdf.js
│   └── pdf.worker.js - core layer
└── web/
├── cmaps/ - character maps(required by core)
├── compatibility.js - polyfills for missing features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed in PR #8819; please rebase your patch to the current master.

Copy link
Contributor Author

@wojtekmaj wojtekmaj Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, sorry for the wait!

Copy link
Collaborator

@Snuffleupagus Snuffleupagus Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't allow merge commits in PRs, please squash this into one commit; see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for additional information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You taught me something today! ;) Done. Thanks!

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@Snuffleupagus Snuffleupagus merged commit c61d197 into mozilla:master Nov 16, 2017
@wojtekmaj wojtekmaj deleted the change/remove-compatibility-from-examples branch November 17, 2017 01:34
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…ility-from-examples

Remove mentions of compatibility.js from examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants