Ensure that the same exact version of PDF.js is used in both the API and the Worker #8959
Conversation
…and the Worker I don't have a good example at hand right know, but I recall seeing custom deployments of PDF.js that bundle a *specific* version of the `build/pdf.js` file and then set `PDFJS.workerSrc` to point to https://mozilla.github.io/pdf.js/build/pdf.worker.js. That practice seems really bad since, besides (obviously) causing unnecessary server load, it will very quickly result in a version mismatch between the `pdf.js` and `pdf.worker.js` files in those PDF.js deployments. Such a version mismatch could easily lead to either breaking errors, or even worse slightly inconsistent behaviour for an API call (if the API -> Worker interface changes, which does happen from time to time). To avoid the problems described above, I'm thus proposing that we enforce that the versions of the `pdf.js` and `pdf.worker.js` files must always match.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/da56ca07c857446/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0b165bbdfc10bec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/da56ca07c857446/output.txt Total script time: 16.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/0b165bbdfc10bec/output.txt Total script time: 22.81 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/33e4e394e554ea2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/33e4e394e554ea2/output.txt Total script time: 2.46 mins Published |
|
@yurydelendik Thank you for the review :-) |
…-check Ensure that the same exact version of PDF.js is used in both the API and the Worker
I don't have a good example at hand right know, but I recall seeing custom deployments of PDF.js that bundle a specific version of the
build/pdf.jsfile and then setPDFJS.workerSrcto point to https://mozilla.github.io/pdf.js/build/pdf.worker.js.That practice seems really bad since, besides (obviously) causing unnecessary server load, it will very quickly result in a version mismatch between the
pdf.jsandpdf.worker.jsfiles in those PDF.js deployments.Such a version mismatch could easily lead to either breaking errors, or even worse slightly inconsistent behaviour for an API call (if the API -> Worker interface changes, which does happen from time to time).
To avoid the problems described above, I'm thus proposing that we enforce that the versions of the
pdf.jsandpdf.worker.jsfiles must always match.