Add UI for the cursorToolOnLoad pref in the Chrome extension + migration logic #8653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing for a release, I encountered the "Don't know how to handle cursorToolOnLoad!" error in the console of the options page. After an investigation, I found that the hand tool preference was converted from a boolean to an integer in #7635.
I fixed the UI and added migration logic - see the commit message for more details.
Test:
Run
gulp chromium
Go to
chrome://extensions
in Chrome, enable Developer mode and load the extension frombuild/chromium/
.Click on Inspect background page of the extension, and run the following code:
Run the following code to confirm that the preference has been migrated:
Click on the "Options" link and confirm that the "Cursor tool on load" dropdown is set to "Hand Tool".
Optional (to check that the migration logic does not interfere with a normal functioning of the migrated pref):