Don't allow setting various properties, such as currentPageNumber/currentScale/currentScaleValue/pagesRotation, before {PDFViewer, PDFThumbnailViewer}.setDocument has been called
#8555
Conversation
…currentScale`/`currentScaleValue`/`pagesRotation`, before `{PDFViewer, PDFThumbnailViewer}.setDocument` has been called
Currently a number of these properties do not work correctly if set *before* calling `setDocument`; please refer to the discussion starting in #8539 (comment).
Rather than trying to have *some* of these methods working, but not others, it seems much more consistent to simply always require that `setDocument` has been called.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2b973b4b4230022/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2b973b4b4230022/output.txt Total script time: 2.31 mins Published |
There was a problem hiding this comment.
Nice work! I think this makes the code much more consistent and predictable (avoiding subtle bugs). Feel free to merge this if @yurydelendik approves the patch too.
|
This PR contains a proper fix for the underlying issues uncovered by #8539, please refer to #8539 (comment) for all the gory details. |
…pdfDocument-checks
Don't allow setting various properties, such as `currentPageNumber`/`currentScale`/`currentScaleValue`/`pagesRotation`, before `{PDFViewer, PDFThumbnailViewer}.setDocument` has been called
Currently a number of these properties do not work correctly if set before calling
setDocument; please refer to the discussion starting in #8539 (comment).Rather than trying to have some of these methods working, but not others, it seems much more consistent to simply always require that
setDocumenthas been called./cc @timvandermeij Since your comment in #8539 (comment) seems to support doing this.
/cc @yurydelendik I know that #8539 (comment) is a long read, but can you please check that you're OK with that reasoning and this PR?