-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds special case for origin of blob to the compatibility URL. #8515
Conversation
src/shared/compatibility.js
Outdated
case 'blob': | ||
// Special case of blob: -- returns valid origin of _schemaData. | ||
try { | ||
return new JURL(this._schemaData).origin || 'null'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you mean this._schemeData
here, since the above property is always undefined
(applies in the comment below as well)!?
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ac43cab638216dc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ac43cab638216dc/output.txt Total script time: 18.01 mins Published |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 1 Live output at: http://54.67.70.0:8877/846491c8c20987d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/846491c8c20987d/output.txt Total script time: 2.17 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfectly reasonable to me, but I haven't got the necessary hardware to test that it actually fixes the referenced issue.
@yurydelendik If you've successfully tested this, please feel free to land the patch!
I tried using polyfill with blob URL on IE9, and it worked as expected. |
Adds special case for origin of blob to the compatibility URL.
Fixes #7089