-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using pre-built code for testing. #8459
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4acbb7bdbc12cf2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/87ca7b61808c5a3/output.txt |
gulpfile.js
Outdated
return createTestSource('unit'); | ||
}); | ||
|
||
gulp.task('fonttest', function () { | ||
gulp.task('fonttest', ['generic'], function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you also update test/font/jasmine-boot.js
, I don't think this change is necessary!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4acbb7bdbc12cf2/output.txt Total script time: 16.93 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/87ca7b61808c5a3/output.txt Total script time: 29.18 mins
Image differences available at: http://54.215.176.217:8877/87ca7b61808c5a3/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/34da9c465d2c659/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ccb7248cbda1d96/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ccb7248cbda1d96/output.txt Total script time: 16.97 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/34da9c465d2c659/output.txt Total script time: 28.74 mins
Image differences available at: http://54.215.176.217:8877/34da9c465d2c659/reftest-analyzer.html#web=eq.log |
Let's update ref images. /botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ed9c425a289f44f/output.txt |
Hmm, looking at the end of the output from the Windows bot in either in #8459 (comment) (see http://54.215.176.217:8877/87ca7b61808c5a3/output.txt) or #8459 (comment) (see http://54.215.176.217:8877/34da9c465d2c659/output.txt), it seems that not all test actually ran in Firefox! For Firefox, in the first case https://github.com/mozilla/pdf.js/blob/master/test/test_manifest.json#L3409 is the last test in the log; in the second case https://github.com/mozilla/pdf.js/blob/master/test/test_manifest.json#L3395 is the last test. Are the logs just incomplete, or didn't all tests get run in Firefox on the Windows bot? |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ed9c425a289f44f/output.txt Total script time: 27.66 mins
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2637485370b9b9b/output.txt |
I think it's just hitting 200kb maxBuffer limit (https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback) -- it shall be fine when "no-reference" messages will go away. P.S. see e.g. #8448 (comment) |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/2637485370b9b9b/output.txt Total script time: 28.81 mins
|
Landed as part of PR #8284 (obviously with the correct author info). |
(... in hope to fix Chrome failures on test servers)