Use font loader api #5366
Use font loader api #5366
Conversation
This name clashes with the FontFace constructor from the Font Loading CSS module: http://dev.w3.org/csswg/css-font-loading/#font-face-constructor
|
|
||
| isFontLoadingAPISupported: !isWorker && !!document.fonts, | ||
|
|
||
| addNativeFontFace: function fontLoader__addNativeFontFace(nativeFontFace) { |
There was a problem hiding this comment.
nit: fontLoader__addNativeFontFace (and FontFaceObject__createNativeFontFace below), can you use one '_'?
|
That was fast... I think it looks good. /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1671e686e708d3e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/1671e686e708d3e/output.txt Total script time: 0.94 mins Published
|
Rob--W
force-pushed
the
use-font-loader-api
branch
from
6f0092c to
169909a
Compare
Rob--W
force-pushed
the
use-font-loader-api
branch
from
169909a to
d0845df
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/df29877e4d642af/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/334f65f03d33a04/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/df29877e4d642af/output.txt Total script time: 19.47 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/334f65f03d33a04/output.txt Total script time: 22.43 mins
|
|
now using chrome beta /botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f6583cbd1eb57f4/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/f6583cbd1eb57f4/output.txt Total script time: 22.86 mins
Image differences available at: http://107.21.233.14:8877/f6583cbd1eb57f4/reftest-analyzer.html#web=eq.log |
|
could this also affect the print issue we were chasing? |
|
@Rob--W looks good, thank you /botio makeref
@CodingFabian that's implemented for Chrome for now, not sure if that will fix the printing issues atm |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8bd3fb750e825af/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c59abeb015a2a9b/output.txt |
|
@yurydelendik interestingly this does have a effect. the font is right now ok after cleanup, the page size however is broken. |
|
@CodingFabian could you be more specific with STR and browser version(s)? |
|
@CodingFabian can it be a regression from other PRs? |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8bd3fb750e825af/output.txt Total script time: 21.35 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c59abeb015a2a9b/output.txt Total script time: 22.45 mins
|
|
i used the pdf mentioned in #5006. The font comes out fine. I have yet to bisect it. Right now at javaone conference, and wanted to give it a quick check, might bisect it tonight from hotel. |
|
@CodingFabian looks like a10fde1 is first bad commit |
|
/cc @Snuffleupagus |
See #5365.
Tested in Chromium 37 (and verified that it does not break Firefox 32 or Chromium 34).