Groups path commands into single operation #4683

yurydelendik · 2014-04-25T13:34:51Z

No description provided.

yurydelendik · 2014-04-25T13:37:51Z

Trying to get "map" files faster:

http://carto.metro.free.fr/documents/CartoMetroParis.v3.6.pdf
http://www.vrr.de/imperia/md/content/fahrten/stadtlinienplaene/wuppertal_2012.pdf

timvandermeij · 2014-04-25T18:42:09Z

/botio-linux preview

pdfjsbot · 2014-04-25T18:42:10Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/26070e1f991b61e/output.txt

pdfjsbot · 2014-04-25T18:42:32Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/26070e1f991b61e/output.txt

Total script time: 0.37 mins

Published

Viewer: http://107.21.233.14:8877/26070e1f991b61e/web/viewer.html
B2G Viewer: http://107.21.233.14:8877/26070e1f991b61e/extensions/b2g/content/web/viewer.html
Extension: http://107.21.233.14:8877/26070e1f991b61e/extensions/firefox/pdf.js.xpi
Extension (AMO): http://107.21.233.14:8877/26070e1f991b61e/extensions/firefox/pdf.js.amo.xpi

timvandermeij · 2014-04-25T18:46:56Z

The first PDF is goes down from approx. 12 seconds to 9 seconds, the second PDF goes down from approx. 25 seconds to 20 seconds. Rendering also looks more constant. Nice work!

yurydelendik · 2014-04-25T19:21:42Z

.. thinking about further grouping those into set of figures: color + path + stroke + fill group commands

timvandermeij · 2014-04-25T19:49:38Z

One more to test with:

https://www.prorail.nl/sites/default/files/spoorkaart_prorail_april_2013.pdf (before: 70 seconds, after 69 seconds, Adobe: 2.5 seconds)

Regressed:

http://www.esnroma3.com/files/users/trasporto/roma_notte.pdf (TypeError: this.closePath is not a function)
http://www.esnroma3.com/files/users/trasporto/roma_citta.pdf (same as above)

yurydelendik · 2014-04-30T13:39:28Z

Let's land this. Grouping by shape is getting complicates (see groupshapes branch)

/botio test

pdfjsbot · 2014-04-30T13:39:29Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/04715530fa4f316/output.txt

pdfjsbot · 2014-04-30T13:39:29Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9f2a212aa5c8b03/output.txt

pdfjsbot · 2014-04-30T14:01:35Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/04715530fa4f316/output.txt

Total script time: 22.08 mins

Font tests: Passed
Unit tests: FAILED
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/04715530fa4f316/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-04-30T14:05:16Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/9f2a212aa5c8b03/output.txt

Total script time: 25.79 mins

Font tests: Passed
Unit tests: FAILED
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/9f2a212aa5c8b03/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-04-30T14:09:28Z

/botio-windows unittest

pdfjsbot · 2014-04-30T14:09:29Z

From: Bot.io (Windows)

Received

Command cmd_unittest from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b15bff83d3df5ec/output.txt

pdfjsbot · 2014-04-30T14:12:14Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/b15bff83d3df5ec/output.txt

Total script time: 2.74 mins

Unit Tests: Passed

timvandermeij · 2014-04-30T19:12:54Z

/botio test

pdfjsbot · 2014-04-30T19:12:55Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4e45f71a2ce8277/output.txt

pdfjsbot · 2014-04-30T19:12:55Z

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9ce506fa882d782/output.txt

pdfjsbot · 2014-04-30T19:34:57Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/4e45f71a2ce8277/output.txt

Total script time: 22.01 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/4e45f71a2ce8277/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-04-30T19:38:43Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/9ce506fa882d782/output.txt

Total script time: 25.79 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/9ce506fa882d782/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2014-04-30T19:39:35Z

Given that the test failures only affect Firefox, and the fact that the changes are really small, could this by any change be caused by a Firefox update on the bots?

timvandermeij · 2014-05-01T18:59:16Z

Let's test this again now that the latest references have been made.

/botio test

pdfjsbot · 2014-05-01T18:59:18Z

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/7f8eb9e9d7e7346/output.txt

pdfjsbot · 2014-05-01T18:59:18Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b330433c3dab050/output.txt

pdfjsbot · 2014-05-01T19:21:43Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/b330433c3dab050/output.txt

Total script time: 22.41 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/b330433c3dab050/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-05-01T19:25:05Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/7f8eb9e9d7e7346/output.txt

Total script time: 25.79 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/7f8eb9e9d7e7346/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-05-08T20:48:29Z

/botio-windows preview

pdfjsbot · 2014-05-08T20:48:29Z

From: Bot.io (Windows)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/17e040f29cfb281/output.txt

pdfjsbot · 2014-05-08T20:49:23Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/17e040f29cfb281/output.txt

Total script time: 0.89 mins

Published

Viewer: http://107.22.172.223:8877/17e040f29cfb281/web/viewer.html
B2G Viewer: http://107.22.172.223:8877/17e040f29cfb281/extensions/b2g/content/web/viewer.html
Extension: http://107.22.172.223:8877/17e040f29cfb281/extensions/firefox/pdf.js.xpi
Extension (AMO): http://107.22.172.223:8877/17e040f29cfb281/extensions/firefox/pdf.js.amo.xpi

yurydelendik · 2014-05-09T00:32:42Z

/botio test

pdfjsbot · 2014-05-09T00:32:42Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c3e0b80dd38683c/output.txt

pdfjsbot · 2014-05-09T00:32:42Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/50b401eec0ef650/output.txt

pdfjsbot · 2014-05-09T00:56:28Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/50b401eec0ef650/output.txt

Total script time: 23.74 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/50b401eec0ef650/reftest-analyzer.html#web=eq.log

pdfjsbot · 2014-05-09T00:58:17Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/c3e0b80dd38683c/output.txt

Total script time: 25.58 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/c3e0b80dd38683c/reftest-analyzer.html#web=eq.log

yurydelendik · 2014-05-09T02:24:05Z

Okay, looks like commands are split in chunks different way, so small images chunk optimization produce different results. I think we good to go.

/botio makeref

pdfjsbot · 2014-05-09T02:24:05Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5ebec9fee16f1e8/output.txt

pdfjsbot · 2014-05-09T02:24:05Z

From: Bot.io (Linux)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f787c6df6047813/output.txt

pdfjsbot · 2014-05-09T02:48:00Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/5ebec9fee16f1e8/output.txt

Total script time: 23.90 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2014-05-09T02:49:46Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/f787c6df6047813/output.txt

Total script time: 25.67 mins

Lint: Passed
Make references: Passed
Check references: Passed

Groups path commands into single operation

yurydelendik · 2014-05-10T02:03:37Z

http://www.nps.gov/blri/planyourvisit/upload/blrimap-2.pdf

Groups path commands into single command

63d5aae

yurydelendik added a commit that referenced this pull request May 9, 2014

Merge pull request #4683 from yurydelendik/grouppath

a26d28a

Groups path commands into single operation

yurydelendik merged commit a26d28a into mozilla:master May 9, 2014

yurydelendik mentioned this pull request May 9, 2014

Sluggish pdf #4761

Closed

This was referenced May 26, 2014

Extrememly slow rendering on this pdf #2813

Closed

Refactors showText: split type3, remove showSpacedText #4832

Merged

Snuffleupagus mentioned this pull request Oct 4, 2018

improve readability of CanvasGraphics's and SVGGraphics's constructPath #10129

Closed

Groups path commands into single operation #4683

Groups path commands into single operation #4683

Conversation

yurydelendik commented Apr 25, 2014

yurydelendik commented Apr 25, 2014

timvandermeij commented Apr 25, 2014

pdfjsbot commented Apr 25, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Apr 25, 2014

From: Bot.io (Linux)

Success

Published

timvandermeij commented Apr 25, 2014

yurydelendik commented Apr 25, 2014

timvandermeij commented Apr 25, 2014

yurydelendik commented Apr 30, 2014

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Apr 30, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented Apr 30, 2014

From: Bot.io (Linux)

Failed

yurydelendik commented Apr 30, 2014

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Success

timvandermeij commented Apr 30, 2014

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented Apr 30, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented Apr 30, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented Apr 30, 2014

From: Bot.io (Linux)

Failed

Snuffleupagus commented Apr 30, 2014

timvandermeij commented May 1, 2014

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)

Failed

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)

Failed

yurydelendik commented May 8, 2014

pdfjsbot commented May 8, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 8, 2014

From: Bot.io (Windows)

Success

Published

yurydelendik commented May 9, 2014

pdfjsbot commented May 9, 2014

From: Bot.io (Linux)

Received

pdfjsbot commented May 9, 2014

From: Bot.io (Windows)

Received

pdfjsbot commented May 9, 2014

From: Bot.io (Windows)