-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Don't try to use an non-existing canvas when rendering an in visible existing stamp editor #19311
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a4663a9a6f8e0dd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5cf4fc952078c54/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a4663a9a6f8e0dd/output.txt Total script time: 11.09 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5cf4fc952078c54/output.txt Total script time: 27.25 mins
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/489aa885306dd2c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d6c57d5de067473/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d6c57d5de067473/output.txt Total script time: 10.80 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/489aa885306dd2c/output.txt Total script time: 24.80 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with one nit; thank you.
a863e3c
to
60acc3e
Compare
…visible existing stamp editor It fixes mozilla#19239. When the canvas isn't existing the editor has no image: it's fine because the editor is invisible. Once it's made visible, the canvas is set when the annotation layer has been rendered.
60acc3e
to
06f72d5
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b4447c408c8fc2b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c1693c779829ff2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b4447c408c8fc2b/output.txt Total script time: 10.44 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c1693c779829ff2/output.txt Total script time: 25.04 mins
|
It fixes #19239.
When the canvas isn't existing the editor has no image: it's fine because the editor is invisible. Once it's made visible, the canvas is set when the annotation layer has been rendered.