Implement a commit helper function for the freetext integration tests #19291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ink editor integration tests already use a helper function for committing the editor, so this commit mirrors the approach to the freetext editor integration tests. This has multiple advantages: - it improves consistency between the various editor integration tests; - it makes the code easier to read/understand; - it reduces code duplication (220 lines of code removed); - it reduces the number of `getEditorSelector` calls (32 calls removed) that contained hardcoded IDs, which helps to isolate the tests and to simplify follow-up patches.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1e8b61c6e9baf1d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/7dffc96fefb1518/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1e8b61c6e9baf1d/output.txt Total script time: 9.98 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7dffc96fefb1518/output.txt Total script time: 23.30 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ink editor integration tests already use a helper function for committing the editor, so this commit mirrors the approach to the freetext editor integration tests. This has multiple advantages:
getEditorSelectorcalls (32 calls removed) that contained hardcoded IDs, which helps to isolate the tests and to simplify follow-up patches.Fixes a part of #19065.