Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the highlight integration test when highlighting with the keyboard #19111

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix the highlight integration test when highlighting with the keyboard #19111

merged 1 commit into from
Nov 27, 2024

Conversation

calixteman
Copy link
Contributor

These tests were failing with Puppeteer 23.9.0.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/45e4f9ec3118a26/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b86a4a71fe09609/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/45e4f9ec3118a26/output.txt

Total script time: 8.81 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b86a4a71fe09609/output.txt

Total script time: 19.92 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

With this patch and Puppeteer 23.9.0, all the integrations tests are passing locally.
So I'd like to update Puppeteer in order to add some tests for touch screens.

@calixteman
Fix the highlight integration test when highlighting with the keyboard
5d77a64 
These tests were failing with Puppeteer 23.9.0.
@calixteman calixteman force-pushed the fix_highlight_test_with_kb branch from bc6ea5e to 5d77a64 Compare November 27, 2024 14:38
Snuffleupagus
Snuffleupagus approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7ea54dbb99a0094/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f538d4debe05c54/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7ea54dbb99a0094/output.txt

Total script time: 8.83 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f538d4debe05c54/output.txt

Total script time: 20.77 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 052b001 into mozilla:master Nov 27, 2024
7 checks passed
@calixteman calixteman deleted the fix_highlight_test_with_kb branch November 27, 2024 15:10
@timvandermeij timvandermeij removed their request for review November 28, 2024 19:46
@timvandermeij
Copy link
Contributor

Nice find; thank you for fixing this because this one wasn't obvious to me when debugging it!

@timvandermeij timvandermeij mentioned this pull request Nov 28, 2024
Closed
@timvandermeij timvandermeij mentioned this pull request Dec 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus