Fix toolbarViewer/toolbarContainer regressions (PR 18385, 18786 follow-up)
#18831
Conversation
…n` (PR 18385 follow-up) With the changes made in PR 18385 the `toolbarViewer` element is now shorter than before, since the padding is applied on its `toolbarContainer` parent-element instead. This causes two separate regressions: - Clicking at the very top/bottom of the toolbar no longer closes the secondaryToolbar like previously. - The `CaretBrowsingMode`-constructor no longer computes the toolbar-height correctly. Given how/where the `container`-property is being used these changes *should* thus be safe.
Snuffleupagus
changed the title
toolbarViewer/toolbarContainer regressions (PR 18385, 18786 follow-up)
Snuffleupagus
force-pushed
the
toolbar-container
branch
2 times, most recently
from
e9a77f5 to
2ae29ad
Compare
Snuffleupagus
force-pushed
the
toolbar-container
branch
from
7dcab52 to
4f6b90d
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6bfc94253394f7f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/338215ddc51fac7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6bfc94253394f7f/output.txt Total script time: 9.71 mins
|
Snuffleupagus
force-pushed
the
toolbar-container
branch
from
4f6b90d to
89c40f0
Compare
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/338215ddc51fac7/output.txt Total script time: 20.72 mins
|
Snuffleupagus
force-pushed
the
toolbar-container
branch
from
89c40f0 to
6d6c71c
Compare
… preference changes (PR 18786 follow-up) Otherwise the isVisible-calculations may not work correctly.
Snuffleupagus
force-pushed
the
toolbar-container
branch
from
6d6c71c to
07e8afb
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d9301b54db5404e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d9301b54db5404e/output.txt Total script time: 1.01 mins Published |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8c3a9670387d26a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/65e4909d7fae0a9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/65e4909d7fae0a9/output.txt Total script time: 9.65 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8c3a9670387d26a/output.txt Total script time: 19.88 mins
|
Use the "correct" toolbar container element in
getViewerConfiguration(PR 18385 follow-up)With the changes made in PR Refactor the toolbar html & css to improve its overall accessibility (bug 1171799, bug 1855695) #18385 the
toolbarViewerelement is now shorter than before, since the padding is applied on itstoolbarContainerparent-element instead.This causes two separate regressions:
CaretBrowsingMode-constructor no longer computes the toolbar-height correctly.Given how/where the
container-property is being used these changes should thus be safe.Update the
CaretBrowsingModetoolbar-height if thetoolbarDensitypreference changes (PR 18786 follow-up)Otherwise the isVisible-calculations may not work correctly.