Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the toolbar buttons in order to free their current names #18757

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Rename the toolbar buttons in order to free their current names #18757

merged 1 commit into from
Sep 17, 2024

Conversation

calixteman
Copy link
Contributor

which can then be used for their future parent container.
This patch aims to simplify a bit the patch in #18385.

@calixteman calixteman force-pushed the rename_toolbar_buttons branch from f427993 to a7807ca Compare September 17, 2024 16:25
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/abc067771fbf55d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/02cfdbe7509f794/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/abc067771fbf55d/output.txt

Total script time: 9.43 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/02cfdbe7509f794/output.txt

Total script time: 19.10 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3f09db410033bc9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3f09db410033bc9/output.txt

Total script time: 1.01 mins

Published

timvandermeij
timvandermeij approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with two questions. Thank you for extracting another part of the refactoring PR because these smaller steps are much easier to review and check for correctness!

web/viewer.js Show resolved Hide resolved
web/viewer.js Show resolved Hide resolved
@calixteman
Rename the toolbar buttons in order to free their current names
ee89bd1 
which can then be used for their future parent container.
This patch aims to simplify a bit the patch in mozilla#18385.
@calixteman calixteman force-pushed the rename_toolbar_buttons branch from a7807ca to ee89bd1 Compare September 17, 2024 18:34
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91e4022fb9e5daf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1b715c808cf0c39/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1b715c808cf0c39/output.txt

Total script time: 9.32 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/91e4022fb9e5daf/output.txt

Total script time: 19.32 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 19151fe into mozilla:master Sep 17, 2024
6 checks passed
@calixteman calixteman deleted the rename_toolbar_buttons branch September 17, 2024 19:20
@timvandermeij timvandermeij removed the request for review from Snuffleupagus September 21, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @timvandermeij