Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Update the loading icon when wait for ML to take into account prefered-reduced-motion setting #18666

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Aug 30, 2024

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/95a926bf62c64d4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0ef47042f4cb411/output.txt

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed; thank you.

web/images/altText_spinner.svg Outdated Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/95a926bf62c64d4/output.txt

Total script time: 8.68 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/0ef47042f4cb411/output.txt

Total script time: 20.13 mins

  • Integration Tests: Passed

@calixteman calixteman force-pushed the update_loading_icon_alt_text branch from d1e5a19 to d6d0e67 Compare August 30, 2024 13:02
gulpfile.mjs Outdated Show resolved Hide resolved
…t prefered-reduced-motion setting

 * The icon has been updated in https://bugzilla.mozilla.org/show_bug.cgi?id=1908920;
 * Add a linter to check that a svg element doesn't have fill="context-fill" attribute.
@calixteman calixteman force-pushed the update_loading_icon_alt_text branch from d6d0e67 to 36c5d19 Compare August 30, 2024 15:04
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG linting seems helpful.

r=me, thank you.

@calixteman
Copy link
Contributor Author

I made two PRs: https://github.com/simple-icons/svglint/pulls/calixteman in order to not print the summary and to add an ignore list.

@calixteman calixteman merged commit 7494dbc into mozilla:master Aug 30, 2024
8 checks passed
@calixteman calixteman deleted the update_loading_icon_alt_text branch August 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants