Simplify the PDFDocumentProperties.#updateUI method
#18655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
PDFDocumentProperties-updateUI-rm-param
branch
from
055afbc to
7dccf44
Compare
We can remove the `reset`-parameter, since it's redundant, given that it's only used after `PDFDocumentProperties.#reset` has been invoked which means that `this.#fieldData === null` which is equivalent to resetting. Also, we don't need to have two separate loops in order to update the UI in this method. Finally, inline the `DEFAULT_FIELD_CONTENT` constant now that it's only used once.
Snuffleupagus
force-pushed
the
PDFDocumentProperties-updateUI-rm-param
branch
from
7dccf44 to
a5d0e41
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/756650e32921c22/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/756650e32921c22/output.txt Total script time: 1.00 mins Published |
timvandermeij
approved these changes
Aug 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove the
reset-parameter, since it's redundant, given that it's only used afterPDFDocumentProperties.#resethas been invoked which means thatthis.#fieldData === nullwhich is equivalent to resetting.Also, we don't need to have two separate loops in order to update the UI in this method.