Utilize Fluent to format numbers and dates in PDFDocumentProperties/AnnotationLayer
#18638
Conversation
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
2 times, most recently
from
cdc500c to
c2b922e
Compare
Snuffleupagus
changed the title
PDFDocumentPropertiesPDFDocumentProperties/AnnotationLayer
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
from
c2b922e to
e241a47
Compare
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
2 times, most recently
from
eccc61b to
ca3643f
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/459191ca401ebd3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1eece07fd5dad4a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/459191ca401ebd3/output.txt Total script time: 31.34 mins
Image differences available at: http://54.241.84.105:8877/459191ca401ebd3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1eece07fd5dad4a/output.txt Total script time: 45.49 mins
Image differences available at: http://54.193.163.58:8877/1eece07fd5dad4a/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
from
ca3643f to
f40880c
Compare
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
from
f40880c to
7b36df4
Compare
The `PDFDocumentProperties` dialog may not display correctly formatted data, especially in the GENERIC viewer, since it's using native methods[1] that depend on the *browser* locale instead of the viewer locale as intended. At the time when this dialog was introduced that was probably all we could easily do, but with Fluent we're able to improve things since it's got built-in support for formatting numbers and dates. Not only does this simplify the JavaScript code, but it also gives the localizer more fine-grained control of the desired output. Please find additional information here: - https://projectfluent.org/fluent/guide/builtins.html - https://projectfluent.org/fluent/guide/functions.html --- [1] `toLocaleString`, `toLocaleDateString`, and `toLocaleTimeString`.
The `AnnotationLayer` may not display correctly formatted data in PopupAnnotations, especially in the GENERIC viewer, since it's using native methods[1] that depend on the *browser* locale instead of the viewer locale as intended. With Fluent we're able to improve things since it's got built-in support for formatting dates. Not only does this simplify the JavaScript code slightly, but it also gives the localizer more fine-grained control of the desired output. Please find additional information here: - https://projectfluent.org/fluent/guide/builtins.html - https://projectfluent.org/fluent/guide/functions.html --- [1] `toLocaleDateString`, and `toLocaleTimeString`.
Snuffleupagus
force-pushed
the
PDFDocumentProperties-l10n-functions
branch
from
7b36df4 to
6ce9f97
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/cec4a5ae29fbbda/output.txt |
|
@timvandermeij Mind taking a look at the JS-code in the patch, before we land this? |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cec4a5ae29fbbda/output.txt Total script time: 1.04 mins Published |
|
Thank you for improving this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e2a651f3331ab3c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5dabaccbe501dc8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e2a651f3331ab3c/output.txt Total script time: 20.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5dabaccbe501dc8/output.txt Total script time: 26.26 mins
|
Utilize Fluent to format numbers and dates in
PDFDocumentPropertiesThe
PDFDocumentPropertiesdialog may not display correctly formatted data, especially in the GENERIC viewer, since it's using native methods[1] that depend on the browser locale instead of the viewer locale as intended.At the time when this dialog was introduced that was probably all we could easily do, but with Fluent we're able to improve things since it's got built-in support for formatting numbers and dates. Not only does this simplify the JavaScript code, but it also gives the localizer more fine-grained control of the desired output.
Please find additional information here:
[1]
toLocaleString,toLocaleDateString, andtoLocaleTimeString.Utilize Fluent to format dates in the
AnnotationLayerThe
AnnotationLayermay not display correctly formatted data in PopupAnnotations, especially in the GENERIC viewer, since it's using native methods[1] that depend on the browser locale instead of the viewer locale as intended.With Fluent we're able to improve things since it's got built-in support for formatting dates. Not only does this simplify the JavaScript code slightly, but it also gives the localizer more fine-grained control of the desired output.
Please find additional information here:
[1]
toLocaleDateString, andtoLocaleTimeString.