Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Don't add an already added editor (bug 1890367) #17907

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[Editor] Don't add an already added editor (bug 1890367) #17907

merged 1 commit into from
Apr 8, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from Snuffleupagus April 8, 2024 16:09
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2d0504c455dca0f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d1b7bb371107262/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d1b7bb371107262/output.txt

Total script time: 7.43 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/2d0504c455dca0f/output.txt

Total script time: 20.73 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comment fixed.

test/integration/ink_editor_spec.mjs Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/163b177396a411b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/163b177396a411b/output.txt

Total script time: 1.27 mins

Published

@timvandermeij timvandermeij merged commit 30b65ca into mozilla:master Apr 8, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Looks good to me too; thank you for fixing this!

@calixteman calixteman deleted the fix_draw_ink branch April 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus