Fix annotation border style parsing by handling empty dash arrays #17905
Conversation
The PDF specification states that empty dash arrays, i.e. arrays with zero elements, are in fact valid. In that case the dash array simply corresponds to a solid, unbroken line. However, this case was erroneously being flagged as invalid and therefore the annotation was not drawn because its width was set to zero. This commit fixes the issue by allowing dash arrays to have a length of zero.
timvandermeij
force-pushed
the
annotation-dash-array
branch
from
58af964 to
d01a0bd
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e4c434f7d8b9906/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e4c434f7d8b9906/output.txt Total script time: 1.25 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fc6d0d3be49e049/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/17801611b4da915/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fc6d0d3be49e049/output.txt Total script time: 26.30 mins
Image differences available at: http://54.241.84.105:8877/fc6d0d3be49e049/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/17801611b4da915/output.txt Total script time: 43.15 mins
Image differences available at: http://54.193.163.58:8877/17801611b4da915/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/33780e73fcf0ef4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/bfc588e12274707/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/33780e73fcf0ef4/output.txt Total script time: 18.99 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/bfc588e12274707/output.txt Total script time: 26.91 mins
|
The PDF specification states that empty dash arrays, i.e. arrays with zero elements, are in fact valid. In that case the dash array simply corresponds to a solid, unbroken line. However, this case was erroneously being flagged as invalid and therefore the annotation was not drawn because its width was set to zero. This commit fixes the issue by allowing dash arrays to have a length of zero.
Fixes #17904.