Fix the "must highlight text in the right position" integration test #17893
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/894a45f1f9defa4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/74bccdd10f08c9e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/894a45f1f9defa4/output.txt Total script time: 7.37 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/74bccdd10f08c9e/output.txt Total script time: 20.82 mins
|
timvandermeij
force-pushed
the
find-integration-test
branch
from
474a19e to
bcd2760
Compare
This commit implements the following improvements for the test: - Replace the hardcoded highlight padding with a dynamic calculation. It turns out that the amount of padding can differ per system, possibly due to e.g. local (font) settings, which could cause the test to fail. The test now no longer implicitly depends on the environment. - Remove the page offset subtraction. It's only needed for one assertion, and we can simply add the page offset there once. - Improve the "magic" numbers in the test. The number 5 is removed now that the padding calculation made it obsolete, the number 28 is changed to 30 because that's the actual value in the PDF data and the number 4 is explained a bit more to state that the space also counts as a glyph. - Annotate the steps and checks to improve readability of the test and to explain why certain calculations have to be performed.
timvandermeij
force-pushed
the
find-integration-test
branch
from
bcd2760 to
253a733
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/51f66a2d54d223f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6e3ec651cf6b812/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/51f66a2d54d223f/output.txt Total script time: 7.44 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6e3ec651cf6b812/output.txt Total script time: 22.42 mins
|
This commit implements the following improvements for the test:
Fixes #17843. The integration tests now consistently pass locally too 🎉