Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Remove the mark from the highlight element and set its role to mark (bug 1889623) #17885

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[Editor] Remove the mark from the highlight element and set its role to mark (bug 1889623) #17885

merged 1 commit into from
Apr 4, 2024

Conversation

calixteman
Copy link
Contributor

Set aria-label to the highlighted text, this way the focus frame is exactly set on the highlight element and the higlighted text is read.

@calixteman calixteman requested a review from Snuffleupagus April 4, 2024 13:28
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9a9d68d28b067c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cb47292af1971cc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9a9d68d28b067c2/output.txt

Total script time: 7.39 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cb47292af1971cc/output.txt

Total script time: 20.31 mins

  • Integration Tests: FAILED

@calixteman
[Editor] Remove the mark from the highlight element and set its role …
54110de 
…to mark (bug 1889623)

Set aria-label to the highlighted text, this way the focus frame is exactly set
on the highlight element and the higlighted text is read.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7758f882cf992ed/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3319aad396cc82b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3319aad396cc82b/output.txt

Total script time: 7.39 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7758f882cf992ed/output.txt

Total script time: 17.87 mins

  • Integration Tests: Passed

@timvandermeij timvandermeij merged commit a5308e1 into mozilla:master Apr 4, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Looks good; thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
accessibility editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus