Update the Path2D polyfill for Node.js environments
#17830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
path2d-new-polyfill
branch
from
1db41d2 to
b14e4ee
Compare
Snuffleupagus
force-pushed
the
path2d-new-polyfill
branch
from
b14e4ee to
eb0b75b
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1939a31de59b6a9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/83ef169d384de67/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1939a31de59b6a9/output.txt Total script time: 2.51 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/83ef169d384de67/output.txt Total script time: 10.29 mins
|
The polyfill that we use was recently split into two packages, and it now consists of a "core" package and a browser-specific package that build upon the former. Hence we need to update to use the "core" package, and slightly tweak the code that loads/initializes the polyfill; see also https://www.npmjs.com/package/path2d This patch was tested successfully with the [pdf2png example](https://github.com/mozilla/pdf.js/tree/master/examples/node/pdf2png), after running `gulp dist-install` locally, using [this PDF document](https://bug810214.bmoattachments.org/attachment.cgi?id=9254990) which contains Type3-fonts that render using `Path2D`.
Snuffleupagus
force-pushed
the
path2d-new-polyfill
branch
from
eb0b75b to
dc0df0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polyfill that we use was recently split into two packages, and it now consists of a "core" package and a browser-specific package that build upon the former.
Hence we need to update to use the "core" package, and slightly tweak the code that loads/initializes the polyfill; see also https://www.npmjs.com/package/path2d
This patch was tested successfully with the pdf2png example, after running
gulp dist-installlocally, using this PDF document which contains Type3-fonts that render usingPath2D.